Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirrorlist has base href tag #124

Open
poeml opened this issue Jun 5, 2015 · 1 comment
Open

mirrorlist has base href tag #124

poeml opened this issue Jun 5, 2015 · 1 comment
Labels

Comments

@poeml
Copy link
Owner

poeml commented Jun 5, 2015

                                                                              [          ]

Issue migrated (2015-06-05) from old issue tracker http://mirrorbrain.org/issues/issue124

Title    mirrorlist has base href tag
 Priority   bug    Status   chatting
Superseder        Nosy List floeff, poeml
Assigned To poeml Keywords

msg430 (view) Author: floeff Date: 2013-09-15.09:07:56

The mirrorlist command inserts a base href tag, which should be omitted, as it
is not needed for anything - the CSS is not loaded anyways

msg490 (view) Author: poeml Date: 2014-01-30.23:45:33

I'm not sure I understand correctly. The base href tag should be ommitted? It's
inserted only if the MirrorBrainMirrorlistStyleSheet directive is configured in
Apache's config. Otherwise it shouldn't be there.

if (scfg->mirrorlist_stylesheet) {
ap_rprintf(r, " <link type="text/css" rel="stylesheet" href="%s" />\n",
scfg->mirrorlist_stylesheet);
}

Can you explain what you mean?

msg501 (view) Author: floeff Date: 2014-01-31.08:41:34

I have set

MirrorBrainMirrorlistStylesheet "/mirrorbrain.css"
(which is a copy of http://www.poeml.de/~poeml/mirrorbrain.css)

In order to have the output of

mb mirrorlist -f xhtml -i png -I /usr/share/flags/countries/16x11/ -o
/var/www/sites/download.documentfoundation.org/mirmon/allmirrors.html -B
/etc/mirmon/footer -t "The Document Foundation Mirrors" -c "The Document
Foundation Mirrors
Note that this list only contains mirrors that are not
restricted to one specific country or region"

work properly, I have to remove the base href tag, otherwise (IIRC) the images
are not loaded properly.

Or do I choose the wrong approach?

History
         Date          User  Action              Args
2014-01-31 08:41:34 floeff set    messages: + msg501
2014-01-30 23:45:34 poeml  set    status: in-progress -> chatting
                                    messages: + msg490
                                    status: unread -> in-progress
2014-01-22 20:05:50 poeml  set    assignedto: poeml
                                    nosy: + poeml
2013-09-15 09:07:56 floeff create

(end of migrated issue)
@poeml poeml added the bug label Jun 5, 2015
@kelson42
Copy link

I'm impacted too. Why not simply copy http://www.poeml.de/~poeml/mirrorbrain.css to http://mirrorbrain.org/mirrorbrain.css to solve that bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants