Issue63

Title theming of the 'details' page
Priority feature Status resolved
Superseder Nosy List fukawi2, poeml
Assigned To Keywords

Created on 2010-09-17.11:42:56 by fukawi2, last changed by poeml.

Messages
msg266 (view) Author: poeml Date: 2010-09-19.01:34:01
Patch in trunk:

http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8142
http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8143

http://svn.mirrorbrain.org/viewvc/mirrorbrain/trunk/mod_mirrorbrain/mod_mirrorbrai
n.c?r1=8143&r2=8141&pathrev=8143
msg263 (view) Author: poeml Date: 2010-09-19.00:10:08
Thinking further, I wonder whether the <div> container wouldn't be useful always, 
or even more so, if running with the plain built-in HTML. 

In conjunction with the existing MirrorBrainMirrorlistStyleSheet directive it 
would allow some theming as well.
msg262 (view) Author: poeml Date: 2010-09-18.23:52:48
I have a working patch and am about to commit it to trunk. One thing I just 
wonder is if the <div> container should already be included; after all, it could 
also be added into the header and footer HTML. Maybe it is more flexible if it's 
not happening hard-coded in mod_mirrorbrain. On the other hand, one more div 
shouldn't harm either.

It looks like this now:

INJECTED_HEADER
<div id="mirrorbrain-details">
  <h2>Mirrors for ...

    ...
  </ul>
</div> <!-- mirrorbrain-details -->
INJECTED_FOOTER
msg259 (view) Author: poeml Date: 2010-09-18.22:19:30
Adding Apache configuration directives for this purpose is easy and I'm happy to do it 
(at least something I mastered meanwhile ;)

I assume that this implies that the header/footer would be read from disk (resp. out of 
memory) each time, as HeaderName/ReadmeName in mod_autoindex do. But that should be 
okay.
msg241 (view) Author: fukawi2 Date: 2010-09-17.11:42:56
It would be good to be able to include a header and footer to the 'details' page 
to be able to theme it correctly with the rest of the site.

Example:
This page - http://mirror.archserver.org/iso/sums.txt.mirrorlist
Should be themed like this page - http://mirror.archserver.org/iso/

A configuration directive to include a header and/or footer could be added to 
mirrorbrain.conf

If a header is included, then MB should only output a <div> rather than a 
complete page.
History
Date User Action Args
2010-09-19 02:15:17poemlsetstatus: testing -> resolved
2010-09-19 01:34:07poemlsetstatus: chatting -> testing
2010-09-19 01:34:01poemlsetmessages: + msg266
2010-09-19 00:10:08poemlsetmessages: + msg263
2010-09-18 23:52:49poemlsetmessages: + msg262
2010-09-18 22:19:30poemlsetstatus: unread -> chatting
nosy: + poeml
messages: + msg259
2010-09-17 11:42:56fukawi2create