Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap_dbd_open/ap_dbd_close() might be more economic for db connection #44

Closed
poeml opened this issue Jun 5, 2015 · 0 comments
Closed

Comments

@poeml
Copy link
Owner

poeml commented Jun 5, 2015

                                                                                 [          ]

Issue migrated (2015-06-05) from old issue tracker http://mirrorbrain.org/issues/issue44

Title    ap_dbd_open/ap_dbd_close() might be more economic for db connection
             utilization
 Priority  wish                    Status            resolved
Superseder                       Nosy List           poeml
 Assigned                         Keywords           mod_asn
      To

msg144 (view) Author: poeml Date: 2010-03-08.21:24:38

from the old TODO file:

  • check whether usage of explicit ap_dbd_open/ap_dbd_close, instead of the
    ap_dbd_acquire wrapping function, results in better utilization of the database
    connection pool
    but apr_reslist is undergoing some fixes/changes currently (1.2.11 time), so
    let's wait
msg145 (view) Author: poeml Date: 2010-03-08.21:49:41

Those functions are probably much less used than ap_dbd_acquire(), and less
tested. If they work, it'd be nice; it would be important to make sure that no
close() is forgetten in one of the various "quick exit" code paths.

msg146 (view) Author: poeml Date: 2010-03-09.18:16:43

This change would actually be more interesting for mod_asn, than for
mod_mirrorbrain. mod_asn is usually configured to be used for all requests; like
mod_geoip, it runs early enough so it can't be known if the data looked up will
actually be used.

mod_mirrorbrain however can be configured with various exceptions to not handle a
requests at all, and ap_dbd_acquire() runs late (not earlier than needed) and
might not be reached at all. Especially, that stage is not reached for those
requests that actually serve data to clients and might persist for a while
therefore.

msg164 (view) Author: poeml Date: 2010-03-26.23:05:00

Fixed in trunk, r75.

History
         Date         User  Action            Args
2010-03-26 23:05:29 poeml set    status: testing -> resolved
2010-03-26 23:05:01 poeml set    status: deferred -> testing
                                   messages: + msg164
2010-03-09 18:16:43 poeml set    messages: + msg146
                                   keyword: + mod_asn
2010-03-08 21:49:41 poeml set    messages: + msg145
2010-03-08 21:24:38 poeml create

(end of migrated issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant