Re: [mirrorbrain-commits] r7951 - /trunk/mod_mirrorbrain/mod_mirrorbrain.c

From: Peter Pml <poeml_at_cmdline.net>
Date: Wed, 10 Feb 2010 04:08:12 +0100
Hi,

Am 10.02.2010 um 03:54 schrieb poeml_at_mirrorbrain.org:

> Author: poeml
> Date: Wed Feb 10 03:54:18 2010
> New Revision: 7951
> 
> URL: http://svn.mirrorbrain.org/viewvc/mirrorbrain?rev=7951&view=rev
> Log:
> metalink-hasher:
> - Backward compatibility (added around r7793) for old filename scheme
>  ("*.inode_$INODE") in the metalink hash cache removed.


That was wrong (I committed not the file that I intended to commit); the commit message actually should have been:

mod_mirrorbrain:
- On some platforms, filenames for the metalink hash cache weren't constructed
  properly. Using the APR library function apr_off_t_toa() instead of %llu in
  the format string is supposed to fix this. Tracked as issue 35.


I fixed the log message in svn, so the wrong message is gone there.

Peter

> 
> Modified:
>    trunk/mod_mirrorbrain/mod_mirrorbrain.c
> 
> Modified: trunk/mod_mirrorbrain/mod_mirrorbrain.c
> URL: http://svn.mirrorbrain.org/viewvc/mirrorbrain/trunk/mod_mirrorbrain/mod_mirrorbrain.c?rev=7951&r1=7950&r2=7951&view=diff
> ==============================================================================
> --- trunk/mod_mirrorbrain/mod_mirrorbrain.c (original)
> +++ trunk/mod_mirrorbrain/mod_mirrorbrain.c Wed Feb 10 03:54:18 2010
> _at_@ -1684,10 +1684,10 @@
>         /* inject hashes, if they are prepared on-disk */
>         apr_finfo_t sb;
>         const char *hashfilename;     /* the even newer hash filename contains the size of the file */
> -        hashfilename = apr_psprintf(r->pool, "%s%s.size_%llu", 
> +        hashfilename = apr_psprintf(r->pool, "%s%s.size_%s", 
>                                    scfg->metalink_hashes_prefix ? scfg->metalink_hashes_prefix : "", 
>                                    r->filename, 
> -                                   r->finfo.size);
> +                                   apr_off_t_toa(r->pool, r->finfo.size));
> 
>         if (apr_stat(&sb, hashfilename, APR_FINFO_MIN, r->pool) == APR_SUCCESS && (sb.filetype == APR_REG)) {
>             debugLog(r, cfg, "hashfile '%s' exists", hashfilename);
> 
> 
> 
> 
> _______________________________________________
> mirrorbrain-commits mailing list
> Archive: http://mirrorbrain.org/archive/mirrorbrain-commits/
> 
> Note: To remove yourself from this list, send a mail with the content
> 	unsubscribe
> to the address mirrorbrain-commits-request_at_mirrorbrain.org



_______________________________________________
mirrorbrain-commits mailing list
Archive: http://mirrorbrain.org/archive/mirrorbrain-commits/

Note: To remove yourself from this list, send a mail with the content
 	unsubscribe
to the address mirrorbrain-commits-request_at_mirrorbrain.org
Received on Wed Feb 10 2010 - 03:08:20 GMT

This archive was generated by hypermail 2.3.0 : Mon Feb 20 2012 - 23:47:04 GMT